[
https://issues.apache.org/jira/browse/THRIFT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608246#action_12608246
]
Kevin Ballard commented on THRIFT-62:
-------------------------------------
In talking with Kevin Clark, the benchmark this patch provides demonstrates a
significant performance penalty between the old code and the new (new meaning
my recent work). We've narrowed it down to two areas: MemoryBuffer's new
implementation, and Thrift::Struct#initialize calling #dup on default values.
The first issue is addressed by THRIFT-63. The second is still a problem, and I
don't know if there's any way we can fix it, because calling #dup is fairly
important to protect against destructive modification of default values.
> Merge of BinaryProtocolAccelerated for Ruby bindings
> ----------------------------------------------------
>
> Key: THRIFT-62
> URL: https://issues.apache.org/jira/browse/THRIFT-62
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Assignee: Kevin Clark
> Attachments:
> 0001-rb-Merge-BinaryProtocolAccelerated-automake-compat.patch,
> 0002-rb-Add-setup.rb-back.-We-need-it-until-gems-becomes.patch,
> 0003-rb-Fix-rake-test-in-light-of-Kevin-Clark-s-makefi.patch
>
>
> This is the updated patch which adds a C extension to speed up Ruby thrift
> serialization and deserialization. It's largely been reviewed already, but
> should still be looked over. The pre-Apache discussions of the bindings,
> including peer review and modifications happened here:
> http://publists.facebook.com/pipermail/thrift/2008-April/000890.html
> Post that, there have been a few changes prompted by bugs found internally at
> Powerset, and I fixed the read buffering in Thrift::BufferedTransport.
> This patch also adds automake compatability (make check and such) to the Ruby
> bindings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
