[
https://issues.apache.org/jira/browse/THRIFT-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Duxbury updated THRIFT-5:
-------------------------------
Attachment: thrift-5-v6.patch
v6 of changes incorporates Todd and Nathan's suggestions, plus a few more
little optimizations. I also added logging via java.util.Logger in this version.
To address the async method issue, I followed a strategy like the one Todd
suggested with Runnables, except instead I just pass the FrameBuffer itself to
requestInvoke calls. Then, the FrameBuffer runs the invocation via the invoke()
method, allowing it to track its own state much more easily (and without a new
object instantiation each time).
Anyone feel like giving this version a glance over so I know I got it all?
> Need a thread pool server that is fair in terms of invocations, not sockets
> ---------------------------------------------------------------------------
>
> Key: THRIFT-5
> URL: https://issues.apache.org/jira/browse/THRIFT-5
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Attachments: thrift-5-v2.patch, thrift-5-v3.patch, thrift-5-v4.patch,
> thrift-5-v6.patch, thrift-5.patch
>
>
> The current TThreadPoolServer in the Java libraries is suboptimal. If you
> actually limit the upper bound of threads, and you have long-lived clients,
> and you have more clients than you have max allowed threads, then any clients
> in excess of the max number of threads will never be given a time slice to
> execute.
> Conceptually, it seems like the correct behavior here is for the individual
> method invocations to be the items that end up on the thread pool's execution
> queue, not the individual client sockets (as it is now). This would support
> this and other use cases better.
> Perhaps we should do a Half-Sync/Half-Async server to fulfill this goal?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
