[
https://issues.apache.org/jira/browse/THRIFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610333#action_12610333
]
David Reiss commented on THRIFT-67:
-----------------------------------
The most obvious issue that I see with this implementation is that it doesn't
ensure that the full request has been read before it puts a worker thread into
the processing function. Is this correct? The TNonblockingServer
implementations in C++ and now Java use the 4-byte length sent by the framed
transport to read the entire request before beginning processing.
> python non-blocking server
> --------------------------
>
> Key: THRIFT-67
> URL: https://issues.apache.org/jira/browse/THRIFT-67
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Python)
> Reporter: Alexander Shigin
> Attachments: thrift-python-non-blocking.patch
>
>
> Implementation TNonblockingServer for python library.
> There is a couple of question to discuss:
> * it has a slightly different interface for the rest of python servers. I
> think, it's okay: for example TransportFactory hasn't got any sense for
> non-blocking servers;
> * it seems to have a huge ammount of bad grammar in doc strings;
> * finally, I need a review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
