[
https://issues.apache.org/jira/browse/THRIFT-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612703#action_12612703
]
David Reiss commented on THRIFT-73:
-----------------------------------
I'm no nio expert, but this looks good to me, so I can commit it if no one
objects (and you write the commit message :)). One tiny thing that might help
would be a comment right before "state_ = AWAITING_CLOSE;" to remind the reader
that this code only executes in the exception case.
> TNonblockingServer loses client sockets permanently if wire data is corrupt
> ---------------------------------------------------------------------------
>
> Key: THRIFT-73
> URL: https://issues.apache.org/jira/browse/THRIFT-73
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-73.patch
>
>
> We currently have a problem where some bad messages are getting sent through
> to one of our servers. It results in an unhandled exception in
> FrameBuffer.invoke, which kills the worker thread but fails to close that
> socket. The result is a hung client, perpetually waiting for the server to
> start writing.
> The server should be resilient to such message corruption issues and close
> the client socket.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
