[ 
https://issues.apache.org/jira/browse/THRIFT-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623881#action_12623881
 ] 

Bryan Duxbury commented on THRIFT-114:
--------------------------------------

bq. 1/ Unlike in C++, __isset is not respected when writing optional fields.
THRIFT-33

bq. 2/ It is obvious when a non-primitive type was not set.
THRIFT-116

bq. 3/ There is no way to save memory be eliminating __isset when you know you 
won't need it.
Are you suggesting that there should/could be an option for turning off isset 
if you don't require it?

> Isset structure when not using javabeans generator is completely useless
> ------------------------------------------------------------------------
>
>                 Key: THRIFT-114
>                 URL: https://issues.apache.org/jira/browse/THRIFT-114
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java)
>            Reporter: Bryan Duxbury
>            Priority: Minor
>
> If you're not using the javabeans generator, then interactions with __isset 
> are completely unnecessary. The only time they are set is in the constructor, 
> and they are only checked in the .equals method. It seems like code generated 
> without javabeans should just omit this structure (and the attendant code) 
> completely.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to