[
https://issues.apache.org/jira/browse/THRIFT-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625494#action_12625494
]
Mark Slee commented on THRIFT-119:
----------------------------------
+ indent(out) << "if ((skipOptionalNulls && __isset." <<
(*f_iter)->get_name() << " != false) || !skipOptionalNulls) {" << endl;
This condition can be written more succinctly as:
+ indent(out) << "if (!skipOptionalNulls || __isset." <<
(*f_iter)->get_name() << ") {" << endl;
Also, I'm with David on this one. I think the ability to skip nulls is nice,
but I wouldn't expect it as the default. I'd probably be okay with committing
this before we fix the map/set/list stuff, but only if the default parameter
value is false (which I think it should stay as, even after map/set/list is
supported).
> Improved toString for Java Structs
> ----------------------------------
>
> Key: THRIFT-119
> URL: https://issues.apache.org/jira/browse/THRIFT-119
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-119.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
