[
https://issues.apache.org/jira/browse/THRIFT-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628418#action_12628418
]
David Reiss commented on THRIFT-131:
------------------------------------
I don't think there is any problem with this, but the purpose of those methods
is more for internal use by the server. The counters are supposed to be
read-only from the outside world.
> Add convenience counter methods to fb303 thrift file
> ----------------------------------------------------
>
> Key: THRIFT-131
> URL: https://issues.apache.org/jira/browse/THRIFT-131
> Project: Thrift
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Priority: Trivial
>
> Since most of the different FacebookBase classes/files have a version of
> these methods, I suggest adding them to the fb303.thrift file.
> /**
> * increment this counter by 1
> */
> i64 incrementCounter(String key);
> /**
> * Remove this counter and any value associated with it
> */
> void deleteCounter(string key);
> /**
> * Reset this counter to 0
> */
> void resetCounter(string key);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
