We should also remember to propogate changes to python and other
languages which have this issue
Sent from my iPhone
On Sep 8, 2008, at 1:41 PM, Amit Sudharshan <[EMAIL PROTECTED]> wrote:
A thriftexception with a well written message, would have saved
quite a lot of digging to find the anomaly .
Sent from my iPhone
On Sep 8, 2008, at 1:33 PM, "Chad Walters (JIRA)" <[EMAIL PROTECTED]>
wrote:
[ https://issues.apache.org/jira/browse/THRIFT-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629252#action_12629252
]
Chad Walters commented on THRIFT-135:
-------------------------------------
I agree that #1 is best. Perhaps we should make sure this error
condition throws a Thrift exception rather than a Java NPE, though.
Nulls in set<string> throw an exception in Java
-----------------------------------------------
Key: THRIFT-135
URL: https://issues.apache.org/jira/browse/THRIFT-135
Project: Thrift
Issue Type: Bug
Components: Compiler (Java)
Reporter: David Reiss
From Amit Sudharshan:
I recently noticed a bug(feature?) in
com.facebook.thrift.protocol.TBinaryProtocol.writeString where if
it is passed a null pointer it will throw NPE.
Now, the autogenerated stub code tries to prevent this, however we
recently came across a case where we had a Set<String> which
contained a "NULL" (legal in java). Thrift tests to see if the set
is non-null and implicitely whether it has any elements, both of
these pass in this case, and so the null string is passed to the
writeString method where we get the NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
