Ack ... I was hitting the old SVN repository (since that's what comes up
when you search for "thrift svn" on Google).
My patch is arguably slightly better, but the current head is good
enough for our purposes, thanks.
Dave Engberg wrote:
I don't feel qualified to comment on the first part of your email, but
I'm looking at the trunk head, and that still seems to hard-code in
'http://' :
http://svn.facebook.com/svnroot/thrift/trunk/lib/php/src/transport/THttpClient.php
I think my patch might be slightly cleaner, since it allows you to
specify the port correctly. The git diff you sent wouldn't let me use
SSL on any port other than 443, and I'd need to construct the https
THttpClient with a dummy port=80 to work around the hard-coded
assumptions in the rest of the class:
$trans = new THttpClient('www.evernote.com', 80, '/foo', 'https');
David Reiss wrote:
Am I just crazy, or don't we already have this feature?
http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=2c6b42c63c0e757e6b855409804543c059fbbc9b
Mark Slee wrote:
Thanks Dave, this looks fine to me.
The official process is to create a JIRA ticket and attach the patch to
it here:
http://issues.apache.org/jira/browse/THRIFT
Cheers,
Mark
