[
https://issues.apache.org/jira/browse/THRIFT-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638059#action_12638059
]
Michael Greene commented on THRIFT-129:
---------------------------------------
The class itself looks fine. There are a few things I would suggest:
The indentation should probably not change here:
{code}
indent(out) <<
- "public class " << tstruct->get_name() << " ";
+"public class " << tstruct->get_name() << " : ";
{code}
Every line in the .csproj file is marked as removed/added. There's possibly a
CR/LF issue with that file. Can you isolate only your changes?
The header should be updated in light of THRIFT-158, but since this hasn't been
resolved I'm not sure:
bq. Apache mandates a common header that includes a notice about the Apache
Software License. We need to do a sweep and add this header EVERYWHERE.
> Update CSharp compiler and Library to generate data structures that extend
> TBase.cs
> -----------------------------------------------------------------------------------
>
> Key: THRIFT-129
> URL: https://issues.apache.org/jira/browse/THRIFT-129
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#), Library (C#)
> Reporter: Michael Ward
> Attachments: my.patch
>
>
> The C# library does not currently have a base class/interface for the data
> structures being generated to extend from. Without this you are required to
> access the Read(TProtocol) and Write(TProtocol) methods via reflection.
> I have created a patch the defines the TBase class and updates the generator
> to use this for the data structures created. This change is similar to what
> Thrift currently provides for Java.
> Cheers,
> Mike
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
