[ 
https://issues.apache.org/jira/browse/THRIFT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646962#action_12646962
 ] 

Bryan Duxbury commented on THRIFT-185:
--------------------------------------

Very simple test, but looks good. For simplicity, can you produce a single 
patch for both lib and test changes and post as v2?

> Struct doesn't check if struct fields are of proper struct type when 
> Thrift.type_checking is on
> -----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-185
>                 URL: https://issues.apache.org/jira/browse/THRIFT-185
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Bryan Duxbury
>            Priority: Minor
>         Attachments: thrift-185-test.patch, thrift-185.patch
>
>
> When creating a Thrift struct via the constructor, if type_checking is on, 
> you'd expect the code to complain if you pass in the wrong kind of struct. 
> However, the type checking code only verifies that it is a Struct, not that 
> it is the right *kind* of struct. This is inconsistent behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to