[
https://issues.apache.org/jira/browse/THRIFT-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661027#action_12661027
]
David Reiss commented on THRIFT-244:
------------------------------------
LGTM.
> JSON Protocol doesn't extends TProtocolFactory and doesn't write messages
> begin properly
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-244
> URL: https://issues.apache.org/jira/browse/THRIFT-244
> Project: Thrift
> Issue Type: Bug
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Attachments: cpp_JSONProtocol_factory_writeMessageBegin.patch
>
>
> The trunk cpp JSON protocol doesn't work because of two small issues:
> - First part of the writeMessageBegin protocol is to write the Thrift
> Protocol version, which is stored in a uint8_t static variable. Unfortunately
> boost::lexical_cast handles uint8_t as a string type and doesn't write the
> given number. Fixed by moving the variable from uint8_t to uint32_t.
> - The current JSONProtocolFactory implements TProtocolFactory but doesn't
> extend it, so it unuseable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
