[ 
https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663729#action_12663729
 ] 

Esteve Fernandez commented on THRIFT-209:
-----------------------------------------

More info about the virtual keyword: 
http://msdn.microsoft.com/en-us/library/9fkccyh4(VS.80).aspx

_The virtual keyword is used to modify a method, property, indexer or event 
declaration, and allow it to be overridden in a derived class._

The patch is ridiculously small, I can't see any side effects if applied.

> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
>                 Key: THRIFT-209
>                 URL: https://issues.apache.org/jira/browse/THRIFT-209
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C#)
>            Reporter: Esteve Fernandez
>            Assignee: Esteve Fernandez
>         Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, 
> preventing it from being overriden in subclasses.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to