[
https://issues.apache.org/jira/browse/THRIFT-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667902#action_12667902
]
Bryan Duxbury commented on THRIFT-166:
--------------------------------------
The net effect will be this:
{code}
D test/java/TestServer
D test/java/src
D test/java/src/TestServer.java
D test/java/src/OverloadNonblockingServer.java
D test/java/src/DeepCopyTest.java
D test/java/src/IdentityTest.java
D test/java/src/ToStringTest.java
D test/java/src/TestNonblockingServer.java
D test/java/src/JavaBeansTest.java
D test/java/src/EqualityTest.java
D test/java/src/JSONProtoTest.java
D test/java/src/TestClient.java
D test/java/TestNonblockingServer
D test/java/TestClient
D test/java/build.xml
M aclocal/ax_java.m4
M lib/java
A lib/java/test
A + lib/java/test/TestServer
A lib/java/test/org
A lib/java/test/org/apache
A lib/java/test/org/apache/thrift
A lib/java/test/org/apache/thrift/test
A + lib/java/test/org/apache/thrift/test/OverloadNonblockingServer.java
A + lib/java/test/org/apache/thrift/test/TestServer.java
A + lib/java/test/org/apache/thrift/test/DeepCopyTest.java
A + lib/java/test/org/apache/thrift/test/IdentityTest.java
A + lib/java/test/org/apache/thrift/test/ToStringTest.java
A + lib/java/test/org/apache/thrift/test/TestNonblockingServer.java
A + lib/java/test/org/apache/thrift/test/JavaBeansTest.java
A + lib/java/test/org/apache/thrift/test/EqualityTest.java
A + lib/java/test/org/apache/thrift/test/JSONProtoTest.java
A + lib/java/test/org/apache/thrift/test/TestClient.java
A + lib/java/test/TestNonblockingServer
A + lib/java/test/TestClient
M lib/java/build.xml
{code}
Moves in svn show as a delete and an add.
The property file thing is for THRIFT-221, and allows you to specify an
user-computer-specific classpath for the tests, instead of using the hard-coded
/usr/local/share/jars or whatever where the test build file used to expect
commons-lang-2.3.jar to live. I changed it in this path because I didn't see
the point to copying the same busted approach to build files over to the new
combined file.
> Java tests should be in lib/java/test/...
> -----------------------------------------
>
> Key: THRIFT-166
> URL: https://issues.apache.org/jira/browse/THRIFT-166
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-166.patch
>
>
> It's confusing and inconvenient to have the code and tests in separate
> folders. If they were together, the build.xml could allow you to build and
> run the tests in one command without changing directories.
> Would anyone object to moving these tests into lib/java/test? At the same
> time, we could start doing proper packaging and JUnit naming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
