On Thu, Jan 29, 2009 at 02:51, <bryanduxb...@apache.org> wrote: > Author: bryanduxbury > Date: Thu Jan 29 01:51:08 2009 > New Revision: 738708 > > URL: http://svn.apache.org/viewvc?rev=738708&view=rev > Log: > THRIFT-253. java: Enhance FieldMetaData > > The code generator new creates a static map of field id to metadata for each > field, including information like the field TType, class of embedded structs, > required/optional/default, etc. Additionally, on loading, generated classes > statically register their class and metadata map with the global > FieldMetaData map, so you can get the metadata for any TBase-implementing > class easily.
This appears to create the map for fields of a *struct*, but there are similar Integer->Field mappings for exceptions and function argument lists. Shouldn't you record metadata for those, too? Also, none of this metadata contains the docstrings. Sure, that content can be put into java comments and then used to generate static documentation. But there is no allowance for reflection of the docstrings. Cheers, -g
