[ 
https://issues.apache.org/jira/browse/THRIFT-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669095#action_12669095
 ] 

Bryan Duxbury commented on THRIFT-297:
--------------------------------------

The problem with the standard interface is not so much the reading as it is the 
writing. Unless you do kind of a lot of extra work, you will find yourself 
writing a lot of "unset" primitive values to the wire. I view the sparseness of 
Thrift as a *key* feature, and am more than willing to pay the price of using 
accessor methods to maintain the __isset for me. 

Yes, we could recode the generic accessors to just return the raw data, 
ignoring the __isset. However, doing so would mean duplicating code with the 
beans-generated specific field accessors. 

> getFieldValue and setFieldValue should be abstract TBase methods
> ----------------------------------------------------------------
>
>                 Key: THRIFT-297
>                 URL: https://issues.apache.org/jira/browse/THRIFT-297
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java), Library (Java)
>            Reporter: Nathan Marz
>
> Since these methods can be called on every TBase instance, they should be 
> part of the TBase API. These methods are useful in conjunction with the meta 
> data features.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to