[
https://issues.apache.org/jira/browse/THRIFT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669223#action_12669223
]
T Jake Luciani commented on THRIFT-270:
---------------------------------------
looks good, though it was missing a test case that was likley added recently.
+1 I'll be committing soon if there are no objections
> C++ Library Namespaces should be apache::thrift instead of facebook::thrift
> ---------------------------------------------------------------------------
>
> Key: THRIFT-270
> URL: https://issues.apache.org/jira/browse/THRIFT-270
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Priority: Minor
> Attachments: THRIFT-270-patchv2.patch,
> THRIFT-270.cpplib-namespaces.patch
>
>
> The C++ Library is currently namespaced as facebook::thrift, this should be
> renammed to apache::thrift, just as the current discussion about Java library
> namespacing (THRIFT-34)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
