[
https://issues.apache.org/jira/browse/THRIFT-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670608#action_12670608
]
michaelstockton edited comment on THRIFT-254 at 2/4/09 6:33 PM:
-----------------------------------------------------------------
Perl/Haskell. I didn't check Smalltalk. Should the strict read/write defaults
be the same between languages? I think the variance we have causes confusion.
Moreover, the language used in ProtocolException to indicate a bad version --
which seems fairly standard between implementations -- isn't intuitive. In my
situation, I had to dig into thrift to figure out why my ruby client couldn't
interface with a php server.
was (Author: michaelstockton):
Perl/Haskell. I didn't check Smalltalk. Shouldn't the strict read/write
defaults be the same between languages? I think the variance we have causes
confusion. Moreover, the language used in ProtocolException to indicate a bad
version -- which seems fairly standard between implementations -- isn't
intuitive. In my situation, I had to dig into thrift to figure out why my ruby
client couldn't interface with a php server.
> Add optional strict version support to binary protocols
> -------------------------------------------------------
>
> Key: THRIFT-254
> URL: https://issues.apache.org/jira/browse/THRIFT-254
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Michael Stockton
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-254-v2.patch, thrift-254-v3.patch,
> thrift-254.patch
>
>
> Several thrift libraries do not read a thrift version number in messages by
> default. This can cause issues for a ruby user who interacts with thrift
> services written in other languages because the ruby library doesn't support
> an option to disable version validation.
> This patch does not change the default behavior, where thrift version numbers
> are expected, but it does add the option to disable version validation.
> For example:
> Thrift::BinaryProtocol.new(transport, strict_read=false, strict_write=true)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
