[ 
https://issues.apache.org/jira/browse/THRIFT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury resolved THRIFT-321.
----------------------------------

    Resolution: Fixed

I just committed this patch. 

I see what you're saying about testing all the different ways of interacting. I 
guess my objection is that we use code generation instead of some sort of 
in-Java test that generates the objects. We could probably swing that now that 
we have more reflective methods on the Java structs. 

> THRIFT-303 broke EqualityTest
> -----------------------------
>
>                 Key: THRIFT-321
>                 URL: https://issues.apache.org/jira/browse/THRIFT-321
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Java)
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>         Attachments: 
> 0001-THRIFT-321.-java-Fix-broken-tests-in-the-wake-of-r7.patch
>
>
> It looks like I forgot to solve the EqualityTest issues before committing 
> THRIFT-303. This means the Java test suite won't compile.
> Currently, the test is the result of a python script. This seems complex and 
> gratuitous. I think we should replace it with a much shorter, more specific 
> test that isn't generated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to