[
https://issues.apache.org/jira/browse/THRIFT-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672163#action_12672163
]
David Reiss commented on THRIFT-309:
------------------------------------
I'm okay with this.
Too bad about having to define THashSet. Is it possible to allow the user to
put a normal HashSet in their structure (like, by using ISet or something if it
is available)? Or is there no Set interface in .NET 2.0?
Do you mind if I change NET_2_0 to DOT_NET_2_0?
Most (all?) of the C# library files use tabs for indentation (unlike the rest
of Thrift) because that's how it was submitted, but a lot of your code uses
spaces for indentation. I can change your stuff to tabs, or if you and Will
prefer, I can change the whole lib to use spaces instead.
> Thrift should run on plain .NET 2.0 and compatible Mono, with no additional
> dependencies
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-309
> URL: https://issues.apache.org/jira/browse/THRIFT-309
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#), Library (C#)
> Reporter: Michael Greene
> Assignee: Michael Greene
> Fix For: 0.1
>
> Attachments: thrift-309-001.diff
>
>
> The current requirements for Thrift are:
> .NET 3.5 on Visual Studio 2008
> or
> Mono 1.2.6+ with special compiler flags or Mono 2.0 standard
> This does not need to be. We can support the following setup without too
> much difficulty:
> .NET 2.0+ on Visual Studio 2005+
> Mono 1.2.4+ standard
> I think we should, as this has come up several times via complaints on blogs,
> notes on the Wiki, or confusion on the mailing list. .NET 2.0's penetration
> is much higher than 3.5, and this moves support for Thrift out to ~2007 on
> the Mono side and ~2005 on the .NET side versus the current ~2008 for both.
> Just wrapping this up over here, patch will be available later today.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
