[
https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672557#action_12672557
]
Esteve Fernandez commented on THRIFT-325:
-----------------------------------------
I think it would be better to file a separate issue for 0004, 0007, 0008, it
would make it easier to track revisions and issues. Anyway, they look fine.
BTW, I had a quick look at the rest of the patches and they seem to already
include the changes that were in thrift-325.patch. Is there anything I
overlooked?
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
> Attachments: 0001-THRIFT-325.-Include-t_generator.h-in-main.cc.patch,
> 0002-Make-the-Erlang-generator-dynamic.patch,
> 0003-Remove-t_erl_generator.h.patch,
> 0004-Allow-the-Thrift-compiler-to-be-built-without-the-Er.patch,
> 0005-Make-the-XSD-generator-dynamic.patch,
> 0006-Remove-t_xsd_generator.h.patch,
> 0007-Allow-the-Thrift-compiler-to-be-built-without-the-XS.patch,
> 0008-Make-the-XSD-generator-use-non-hardcoded-namespaces.patch,
> 0009-Make-the-PHP-generator-dynamic.patch,
> 0010-Remove-t_php_generator.h.patch,
> 0011-Allow-the-Thrift-compiler-to-be-built-without-the-PH.patch,
> 0012-Make-the-PHP-generator-use-non-hardcoded-namespaces.patch,
> 0013-THRIFT-325.-Remove-a-bunch-of-uses-of-the-old-comman.patch,
> thrift-325.patch
>
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options
> (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
