[ 
https://issues.apache.org/jira/browse/THRIFT-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672928#action_12672928
 ] 

jdugan edited comment on THRIFT-340 at 2/12/09 1:47 AM:
-----------------------------------------------------------

Here's a patch to fix lib/py/src/protocol/fastbinary.c.  __BYTE_ORDER isn't 
defined on FreeBSD and OS X, but BYTE_ORDER is.  I found this in  
lib/cpp/src/protocol/TProtocol.h and transplanted it into fastbinary.c.  See 
comment in original... ;)




      was (Author: jdugan):
    Here's a patch to fix lib/py/src/protocol/fastbinary.c.  __BYTE_ORDER isn't 
defined on FreeBSD and Linux, but BYTE_ORDER is.  I found this in  
lib/cpp/src/protocol/TProtocol.h and transplanted it into fastbinary.c.  See 
comment in original... ;)



  
> TBinaryProtocol and TBinaryProtocolAccelerated produce different values for 
> at least the i64 type.
> --------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-340
>                 URL: https://issues.apache.org/jira/browse/THRIFT-340
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>         Environment: FreeBSD 7
>            Reporter: Jon Dugan
>         Attachments: bug340.tar.gz, thrift_py_fastbinary_endian.patch
>
>
> TBinaryProtocol and TBinaryProtocolAccelerated produce different values for 
> at least the i64 type.
> I don't have a nicely broken out example, but this is very easy to reproduce. 
>  I can generate an example if needed.  
> This was true in the snapshot of the SVN repo from Jan 9, 2009.  I checked 
> recent commits and didn't see anything to address it.
> This appears to be very similar to THRIFT-313.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to