[
https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673121#action_12673121
]
Michael Greene commented on THRIFT-210:
---------------------------------------
* The new file should also be included in Thrift.csproj
* The {{using System.Text;}} statement is unnecessary.
* The code betrays its Java origins a little too much. The rest of our C#
code doesn't add encapsulation modifiers to variable names, so I'd prefer to
leave the {{_}} off.
I'd like to see some tests if possible. The other transports get exercised in
the admittedly simple functional tests.
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: thrift-210.patch, thrift-210_v2.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but
> depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
