[
https://issues.apache.org/jira/browse/THRIFT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679697#action_12679697
]
Kevin Clark commented on THRIFT-229:
------------------------------------
Sorry for the wait on feedback for this one Robey. I'm getting the exact same
failures as Bryan above. It's because the mocks in the specs aren't returning
anything from the fake Socket.new. Lines 24 and 31 should be like:
::Socket.should_receive(:new).and_return(mock("Handle",
:connect_nonblock => true))
If you tweak the patch, I'll commit. Thanks, and really sorry for the wait.
> ruby client timeout does not affect connect()
> ---------------------------------------------
>
> Key: THRIFT-229
> URL: https://issues.apache.org/jira/browse/THRIFT-229
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Environment: all
> Reporter: Robey Pointer
> Assignee: Bryan Duxbury
> Fix For: 0.1
>
> Attachments: patch-2.txt, patch-3.txt, thrift-229.patch
>
>
> the ruby library does not wrap client connect() calls in a timeout select. so
> a ruby thrift client could be blocked in connect() indefinitely.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
