[
https://issues.apache.org/jira/browse/THRIFT-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683987#action_12683987
]
Todd Lipcon commented on THRIFT-136:
------------------------------------
Erlang lgtm though we should make sure this makes it into the release notes. As
you mentioned, you'll have to regenerate the code, upgrade the thrift lib code,
compile everything, and then simultaneously reload thrift_processor as well as
the generated modules for your service.
While I dislike breaking changes like this, it's not the end of the world, and
I think it's preferable to have consistent naming.
> Rename "async void" to "noreturn void" or just "noreturn"
> ---------------------------------------------------------
>
> Key: THRIFT-136
> URL: https://issues.apache.org/jira/browse/THRIFT-136
> Project: Thrift
> Issue Type: Improvement
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments:
> 0001-THRIFT-136.-s-async-oneway-in-lexer-and-parser-vari.patch,
> 0002-THRIFT-136.-s-async-oneway-in-compiler-variables.patch,
> 0003-THRIFT-136.-s-async-oneway-in-comments.patch,
> 0004-THRIFT-136.-s-async-oneway-in-misc-places.patch,
> 0005-THRIFT-136.-s-async-oneway-in-Erlang.patch,
> 0006-THRIFT-136.-s-async-oneway-in-the-Thrift-IDL.patch
>
>
> "async" is not a very descriptive name for functions that don't return any
> value. I suggest that we change this keyword to "noreturn" to free up the
> term "async" to refer to non-blocking function calls. Votes?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
