[
https://issues.apache.org/jira/browse/THRIFT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Duxbury updated THRIFT-275:
---------------------------------
Attachment: thrift-275.patch
This patch removes all the deprecation stuff and the t*.rb classes that were
only placeholders. In addition, I've changed the implementations of some
"abstract" methods to throw NotImplementedError instead of returning nil, and
fixed the test accordingly. Finally, I removed the no longer required borrow
and consume methods from all the transport implementations that had them.
(Borrow and consume have been supplanted by the thrift_native package.)
All the specs and unit test pass, so I think the job is done. It seems like the
only documentation that needs to be made is to indicate that when you see
{code}no such file "thrift/thrift"{code}
you just change it to
{code}require "thrift"{code}
and your problems more or less go away. (You will have to replace the T with
Thrift:: on some declarations, but that's pretty easy too.)
I'd love to have this reviewed and get it committed.
> Remove deprecated classes from Ruby library
> -------------------------------------------
>
> Key: THRIFT-275
> URL: https://issues.apache.org/jira/browse/THRIFT-275
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-275.patch
>
>
> There are a lot of weirdly named files in the Ruby Thrift library in order
> for backwards compatibility to work. I think this is of dubious value, and is
> really confusing. The deprecation code is also very complicated.
> I think we should just get rid of the backwards-compatibility deprecated
> stuff. We're pre-version 1.0, so better to get all the big changes in now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
