[ https://issues.apache.org/jira/browse/THRIFT-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688334#action_12688334 ]
Alexander Shigin commented on THRIFT-395: ----------------------------------------- > That's a nonsensical statement. There is no encoding inherent to unicode > objects. Here is a snippet from your patch: {code} def readString(self): len = self.readI32() str = self.trans.readAll(len) - return str {code} Why do you think the input encoding would be utf-8? > but my understanding is that fastbinary already has some limitations, I know the only limitation is THRIFT-105. And the fastbinary wouldn't be used in this case. Your case is different, you should check if any field has string type to stop using fastbinary. > Python library + compiler does not support unicode strings > ---------------------------------------------------------- > > Key: THRIFT-395 > URL: https://issues.apache.org/jira/browse/THRIFT-395 > Project: Thrift > Issue Type: Bug > Components: Compiler (Python) > Reporter: Jonathan Ellis > Assignee: Jonathan Ellis > Priority: Blocker > Attachments: python-utf8.patch > > > Effectively, all strings in the python bindings are treated as binary strings > -- no encoding/decoding to UTF-8 is done. So if a unicode object is passed > to a (regular, non-binary) string, an exception is raised. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.