[ 
https://issues.apache.org/jira/browse/THRIFT-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688371#action_12688371
 ] 

Jonathan Ellis commented on THRIFT-395:
---------------------------------------

First, what part of this fails to work when you re-generate your API with a 
`binary` type using the included patch?  The code is exactly the same as used 
to be followed for all `string`.

Second, it's disingenuous to claim that a patch that fixes a bug preventing 
python code from working with any other client/server "breaks compatibility."  
Rather it improves compatibility, at the cost of requiring a trivial change 
from people already working around the bug instead of fixing it.

> Python library + compiler does not support unicode strings
> ----------------------------------------------------------
>
>                 Key: THRIFT-395
>                 URL: https://issues.apache.org/jira/browse/THRIFT-395
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Python), Library (Python)
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Blocker
>         Attachments: python-utf8.patch
>
>
> Effectively, all strings in the python bindings are treated as binary strings 
> -- no encoding/decoding to UTF-8 is done.  So if a unicode object is passed 
> to a (regular, non-binary) string, an exception is raised.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to