[
https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688519#action_12688519
]
Chad Walters commented on THRIFT-323:
-------------------------------------
Not sure. I looked the code over and it seems like a pretty direct translation
of my original Java implementation so it seems just great to me! Of course, I
don't actually know any C# so I could be missing something.
WRT Michael's comments above:
-- I looked a little at the Base64 conversion methods in System.Convert and the
methods there are not suitable for this usage because they don't operate from
byte[] to byte[]. Unless there are other standard Base64 methods in C# that I
couldn't turn up with some basic web searches, I think Fredrik's port of my
Java Base64Utils is the right way to go.
-- I am not sure what is being done with tabs versus spaces by convention in
Thrift. I thought I saw an earlier post where David was converting other C#
patches to use tabs, so maybe he can do the same here.
-- The headers in the patch have not yet been updated to remove the author tags
and put in the ASF header.
So, modulo the tabs/spaces issue and the header, I think it is good to go.
Someone want to revise the patch with those fixups?
> TJSONProtocol
> -------------
>
> Key: THRIFT-323
> URL: https://issues.apache.org/jira/browse/THRIFT-323
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Fredrik Hedberg
> Priority: Minor
> Attachments: thrift-csharp-json-3.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
