[
https://issues.apache.org/jira/browse/THRIFT-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688627#action_12688627
]
Alexander Shigin commented on THRIFT-333:
-----------------------------------------
{code}
+uint32_t TCompactProtocol::readBinary(std::string& str) {
...
+ rsize += readVarint32(size);
+ if (size == 0)
+ return 0;
{code}
It seems the string should be nulled. TBinaryProtocol.readString null the
string if gets zero size. I can't give you an example of user or generated code
which depend on it right now.
> Compact Protocol for C++
> ------------------------
>
> Key: THRIFT-333
> URL: https://issues.apache.org/jira/browse/THRIFT-333
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (C++)
> Reporter: Bryan Duxbury
> Assignee: Jérémie BORDIER
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: THRIFT_333_CPP_Compact_Protocol.patch,
> THRIFT_333_CPP_Compact_Protocol.v2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
