[
https://issues.apache.org/jira/browse/THRIFT-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694654#action_12694654
]
Chad Walters commented on THRIFT-395:
-------------------------------------
WRT backwards compatibility breaking changes, my sympathies lie on the side of
biting off a set of compatibility-breaking changes before the first release.
The biggest proponents of full backwards compatibility have probably been David
and Ben. I don't think it is a coincidence that they are also the ones with the
biggest existing investment in persisted Thrift data. I think we need to at
least respect the fact that Facebook had made a big investment in Thrift prior
to open-sourcing it and that we can't strand Facebook completely in decisions
that we make to fix earlier warts.
bq. b. nobody is forcing you to upgrade. if svn 700000-whatever of thrift works
for you, keep using it. if necessary, backporting fixes to a branch is not an
unheard-of strategy either.
I don't think it is reasonable to ask Facebook to do this.
bq. c. you have to weigh the pain against current users from changing behavior,
to pain for future users from NOT changing. hopefully the current user base is
a fraction of what it will be in a few years. unicode is not going to get less
popular in that time.
I agree completely with you on this one -- I do wish the existing users would
sign up for this even at the expense of some amount of pain now in the interest
of the future of the project.
bq. d. if you can't change broken behavior before there is an official release,
when CAN you change it?
I also agree with you on this one.
However, and despite my agreement, I don't see this changing unless David and
Ben sign up to it.
In the absence of that, I think adding a new type might be the best course of
action.
> Python library + compiler does not support unicode strings
> ----------------------------------------------------------
>
> Key: THRIFT-395
> URL: https://issues.apache.org/jira/browse/THRIFT-395
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Python), Library (Python)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Blocker
> Fix For: 0.1
>
> Attachments:
> 0001-python-Minor-cleanup-of-protocols-don-t-use-str.patch,
> 0002-THRIFT-395.-python-Phase-One-of-support-for-unicode.patch,
> 0003-THRIFT-395.-python-Phase-Two-of-support-for-unicode.patch,
> 0004-python-Remove-ridiculous-semicolons-from-gen-code.patch,
> python-utf8-v2.patch, python-utf8.patch
>
>
> Effectively, all strings in the python bindings are treated as binary strings
> -- no encoding/decoding to UTF-8 is done. So if a unicode object is passed
> to a (regular, non-binary) string, an exception is raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
