[ 
https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695502#action_12695502
 ] 

Bryan Duxbury commented on THRIFT-421:
--------------------------------------

I'd say this patch looks good. We need to note that your require statements are 
going to break in the changelog though.

> underscore output file names and require file statements
> --------------------------------------------------------
>
>                 Key: THRIFT-421
>                 URL: https://issues.apache.org/jira/browse/THRIFT-421
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Ruby), Library (Ruby)
>            Reporter: Michael Stockton
>            Assignee: Michael Stockton
>            Priority: Trivial
>         Attachments: thrift-421-v2.patch, thrift-421.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to