[
https://issues.apache.org/jira/browse/THRIFT-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712204#action_12712204
]
Bryan Duxbury commented on THRIFT-434:
--------------------------------------
This patch looks pretty good. Is it missing something, or can I commit it? Do
we want to mix in those php reserved words too?
> ruby compiler should warn when a reserved word is used
> ------------------------------------------------------
>
> Key: THRIFT-434
> URL: https://issues.apache.org/jira/browse/THRIFT-434
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General), Compiler (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-434.patch
>
>
> It would be nice if the compiler would warn or fail when a reserved word is
> used as a struct name, service name or field name. The following names should
> be avoided:
> __FILE__
> and
> def
> end
> in
> or
> self
> unless
> __LINE__
> begin
> defined?
> ensure
> module
> redo
> super
> until
> BEGIN
> break
> do
> false
> next
> rescue
> then
> when
> END
> case
> else
> for
> nil
> retry
> true
> while
> alias
> class
> elsif
> if
> not
> return
> undef
> yield
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
