If you want to submit a patch, I would gladly commit it.

On Aug 11, 2009, at 7:21 AM, Mathias Herberts wrote:

Hi,

I noticed that logging in several Thrift classes:

TNonblockingServer
TSimpleServer
TThreadPoolServer
TIOStreamTransport
TServerSocket
TSocket

and in all generated classes

is done using log4j directly, wouldn't it be preferable to use
commons-logging instead? Thrift would then be more coherent with the
intro statement on the Commons Logging site:

"...a library cannot impose the use of a particular [logging
implementation] on the overall application that the library is a part
of."

Mathias.

Reply via email to