[
https://issues.apache.org/jira/browse/THRIFT-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754652#action_12754652
]
Bruce Simpson commented on THRIFT-311:
--------------------------------------
I like the intent behind this change, but I'm concerned that it may be a lot
for the Thrift guys to digest at once.
I'm running 'conservative', because it seems that moving to ASIO for the
project I'm working on may be too much to take on just right now.
To constrain the scope of the changes, it might be an idea to limit the changes
to *only* the TAsioNonblockingServer, and any changes needed inside the
concurrency/ part of the library. ASIO need not imply dependency on
Boost.Thread.
I suspect that for what Rush is trying to do for his client, Boost.Thread is
needed. Building one's own rwlocks or condvars on Win32 is generally not
advisable if you like quick satisfaction...
Having said all that, this work is an excellent starting point.
> ASIO client & server
> --------------------
>
> Key: THRIFT-311
> URL: https://issues.apache.org/jira/browse/THRIFT-311
> Project: Thrift
> Issue Type: Sub-task
> Components: Library (C++)
> Reporter: Esteve Fernandez
> Attachments: MsvcPatchSupportScripts.zip, thrift-808166-Patched.zip,
> thrift_connection.cpp, thrift_connection.hpp, thrift_connection_v2.cpp,
> thrift_handler.cpp, thrift_handler.hpp, thrift_main.cpp, thrift_server.cpp,
> thrift_server.hpp, ThriftCalculatorASIOServer.cpp,
> ThriftMsvcPatchForSvnRev803313.txt,
> ThriftMsvcPatchForSvnRev803313_Rev1.txt.zip,
> ThriftMsvcPatchForSvnRev808166.txt.zip
>
>
> Given the recent discussion on a Windows port and moving to ASIO
> (http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/200901.mbox/%[email protected]%3e),
> I decided to hack a little Thrift asynchronous prototype server using ASIO
> and here's the result. It implements the Calculator service that can be found
> in the tutorial and, just like TNonblockingServer, it uses a FramedTransport.
> It's just a quick prototype, but I think it's enough for building a more
> generic server/protocol. I've only tested it in Linux, but I think there's
> nothing platform-dependent and can be compiled "as is" in Windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
