[ 
https://issues.apache.org/jira/browse/THRIFT-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury updated THRIFT-723:
---------------------------------

    Attachment: thrift-723-v2.patch

OK, I reworked your patch to fit in with the new test suite. I also simplified 
the changes needed to the compiler - with this change to support sets and maps, 
*every* thrift struct can now be compared. I'll commit this shortly.

> Thrift buffers with set and map types in Java should implement Comparable
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-723
>                 URL: https://issues.apache.org/jira/browse/THRIFT-723
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java), Library (Java)
>            Reporter: Dmitry Chechik
>            Assignee: Bryan Duxbury
>         Attachments: thrift-723-v2.patch, thrift-compare-to.patch
>
>
> Currently, Thrift objects in Java don't implement Comparable if any field is 
> a set or a map.
> The patch attached implements Comparable for those cases. If we can compare a 
> List, we should be able to compare a Set just as easily. This implementation 
> compares two thrift objects by comparing the sorted entries of each set or 
> map.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to