[ https://issues.apache.org/jira/browse/THRIFT-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860070#action_12860070 ]
David Reiss commented on THRIFT-601: ------------------------------------ Okay. I've tested out this patch and it fixes the large frame problem for the thread pool server. There is still the problem of protocol-level problems (like the one in the bug report). It turns out that TBinaryProtocol.Factory doesn't have a way to call setReadLength on the protocol objects it creates, so I'll have to add that. > sending random data crashes thrift service > ------------------------------------------ > > Key: THRIFT-601 > URL: https://issues.apache.org/jira/browse/THRIFT-601 > Project: Thrift > Issue Type: Bug > Components: Library (Java) > Affects Versions: 0.2 > Reporter: Eric Evans > Priority: Critical > Attachments: thrift-601-v2.patch, thrift-601.patch > > > Sending random data to a Java thrift service causes it to crash with extreme > prejudice. > dd if=/dev/urandom count=1 | nc $host 9160 > ... produces ... > java.lang.OutOfMemoryError: Java heap space > at > org.apache.thrift.protocol.TBinaryProtocol.readStringBody(TBinaryProtocol.java:296) > at > org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:203) > at > org.apache.cassandra.service.Cassandra$Processor.process(Cassandra.java:615) > at > org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:253) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) > at java.lang.Thread.run(Thread.java:636) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.