[ 
https://issues.apache.org/jira/browse/THRIFT-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862375#action_12862375
 ] 

Doug Cutting commented on THRIFT-765:
-------------------------------------

Milind claims in AVRO-532 that Hadoop's record io correctlly handled surrogate 
pairs.

https://svn.apache.org/repos/asf/hadoop/common/branches/pre-HADOOP-4687/src/core/org/apache/hadoop/record/Utils.java

That code is quite different from the code in this patch.  Notably, it calls 
String#getCodePoint() and StringBuffer#appendCodePoint() to let Java implement 
surrogate pairs.


> Improved string encoding and decoding performance
> -------------------------------------------------
>
>                 Key: THRIFT-765
>                 URL: https://issues.apache.org/jira/browse/THRIFT-765
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Java)
>    Affects Versions: 0.2
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>             Fix For: 0.3
>
>         Attachments: thrift-765.patch
>
>
> One of the most consistent time-consuming spots of Thrift serialization and 
> deserialization is string encoding. For some inscrutable reason, 
> String.getBytes("UTF-8") is slow. 
> However, it's recently been brought to my attention that DataOutputStream's 
> writeUTF method has a faster implementation of UTF-8 encoding and decoding. 
> We should use this style of encoding.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to