[ https://issues.apache.org/jira/browse/THRIFT-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863817#action_12863817 ]
Bryan Duxbury commented on THRIFT-647: -------------------------------------- David - are you planning to apply that extra "style" patch you attached? I have no problem with you just committing it. > PHP library is missing install target > ------------------------------------- > > Key: THRIFT-647 > URL: https://issues.apache.org/jira/browse/THRIFT-647 > Project: Thrift > Issue Type: Bug > Components: Library (PHP) > Affects Versions: 0.2 > Reporter: Anthony Molinaro > Assignee: Anthony Molinaro > Fix For: 0.4 > > Attachments: Makefile.am, php.patch, > v1-0001-THRIFT-647.-php-Add-license-header-and-fix-style-in-.patch > > > It would be useful when php is detected to install the php library on the > system the same way other libraries are installed. > To do this I added the attached Makefile.am into the lib/php directory and > modifed configure.ac and lib/Makefile.am to cause automake to recognize it > when PHP is installed. It defaults to installing in /usr/lib/php but can be > overridden using the PHP_PREFIX environment variable, similar to python and > java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.