[ 
https://issues.apache.org/jira/browse/THRIFT-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886132#action_12886132
 ] 

Bryan Duxbury commented on THRIFT-815:
--------------------------------------

Well for starters, you should amend the test to check not just the length but 
the contents. From there, I would look into the protocol implementation for 
bugs. I'm neither a Thrift-JS contributor nor user, so I can't provide much 
more detail than that. If you find yourself with questions about the 
architecture of Thrift in general, feel free to toss questions up on the dev 
mailing list or find me in #thrift on freenode.

> Deserialization of lists is critically broken.
> ----------------------------------------------
>
>                 Key: THRIFT-815
>                 URL: https://issues.apache.org/jira/browse/THRIFT-815
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (JavaScript)
>    Affects Versions: 0.4
>            Reporter: Jordan
>            Priority: Critical
>
> Edit the test code that comes with the js language target:
>   var list = [1,2,3]; 
>   var ret = client.testList(list);
>   debugger;
> ret comes back as [3,3,3] when it should be echoed back as [1,2,3]
> The test case never caught this because it only verified the size, and not 
> the contents of the returned array. 
> I cannot find an immediate workaround, but I will try wrapping it in a dummy 
> type like ListServiceResponse. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to