Where is this RAT tool? I'd never heard of it before sebb@ mentioned he used it.
I'll have a look at the NOTICE as well. The MD5 hash was included in the original vote email I sent out, and I think it just managed to go uncopied when it was sent to gene...@. Is there a file I'm supposed to put somewhere? I will try to get a new tarball up with these fixes today or over the weekend. -Bryan On Fri, Jul 23, 2010 at 10:12 AM, Doug Cutting <cutt...@apache.org> wrote: > The sig checks out, and tests pass, but RAT finds a few license issues, as > noted also by sebb on gene...@. > > It would make this check simpler if Thrift included a rat excludes file, as > many of the files that RAT identifies are not a problem, e.g., m4 files, > which are hard to stick licenses into, or Bison generated files, whose > license has an exception. But there are at least a few files that can and > should contain the Apache license but which do not, e.g.: > > lib/java/src/org/apache/thrift/TFieldIdEnum.java > lib/java/test/org/apache/thrift/protocol/TestTBinaryProtocol.java > > Sebb also noted that the NOTICE file contains the wrong date, and that no > MD5 or SHA1 hash files were generated for the tarball. > > Bryan, are you able to fix these and roll another candidate? > > Doug > > > On 06/24/2010 07:08 AM, Bryan Duxbury wrote: > >> Hey all, >> >> After finding some problems with RC4, here we go again! >> >> I propose we accept >> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz>as >> the >> official Thrift 0.3.0 release. It was created by checking out the 0.3.0 >> branch and running "make dist". >> >> The GPG signature can be found at >> http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc5.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc5.tar.gz.asc>, >> and the >> tarball has an MD5 sum of 0c57277cbe0479b81dfed7e72a382036. >> >> Please download, verify the sum and signature, untar, and build the >> compiler >> and libraries of your choice. >> >> Looking forward to your +1 votes! >> >> -Bryan >> >>
