[
https://issues.apache.org/jira/browse/THRIFT-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897543#action_12897543
]
Bryan Duxbury commented on THRIFT-777:
--------------------------------------
Jan - can you post the patch on this issue and check the ASF contribution box?
I'll review it for commit then. (Sorry about the long wait for attention.)
> PHP 5.3 namespaces
> ------------------
>
> Key: THRIFT-777
> URL: https://issues.apache.org/jira/browse/THRIFT-777
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (PHP)
> Reporter: Jan Dolecek
> Priority: Minor
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> I've created patch, with which you can generated namespaces as defines in
> PHP5.3, i.e. \Thrift\SharedServiceIf etc.
> With this patch, thrift php generator will recognize two new parameters:
> - namespace53 - generate namespaces as defines in PHP 5.3. Without it, it
> generates same code as before
> - nsglobal - global namespace, default is Thrift. From tutorial, it will
> create classes \Thrift\tutorial\CalculatorIf etc.
> What can I do to make it attached to trunk? Thanks for any ideas, because
> I'm very new to Thrift and also open-source development.
> Link: http://helemik.cz/juzna/opensource/php/thrift/php53.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
