[ https://issues.apache.org/jira/browse/THRIFT-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898263#action_12898263 ]
Harlan Lieberman-Berg commented on THRIFT-731: ---------------------------------------------- 1) I think that we should abort. If we are in that loop, then the user has specified that they were looking for the java components to be built. It would seem contrary to *nix practice to make the decision for the user. I think aborting with an explanatory message is a better choice... but I can code it either way. 2) You're correct. I just did a straight string comparison for simplicities sake and missed the edge case. I will think of a better way to do this and roll it into the next patch once I hear back about 1. > configure doesn't check for ant >= 1.7 > -------------------------------------- > > Key: THRIFT-731 > URL: https://issues.apache.org/jira/browse/THRIFT-731 > Project: Thrift > Issue Type: Bug > Components: Compiler (Java) > Reporter: Henry Robinson > Assignee: Harlan Lieberman-Berg > Priority: Minor > Fix For: 0.5 > > Attachments: ant.diff, configure.diff > > > ./configure on a machine with ant 1.6 successfully runs, even though it's > required for the Java build step - otherwise you get > BUILD FAILED > /home/henry/thrift-0.2.0/lib/java/build.xml:86: Class > org.apache.tools.ant.taskdefs.ConditionTask doesn't support the nested > "typefound" element. > Upgrading to ant 1.7.1 fixed the build failure, but would be nice if > configure gave a clue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.