[
https://issues.apache.org/jira/browse/THRIFT-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899276#action_12899276
]
Anthony Molinaro commented on THRIFT-854:
-----------------------------------------
Oh, I didn't know about the spec file in contrib, I'll have to take a look. As
for phpize being specific to a particular php installation, I can't say for
sure.
I did the following test which makes me think it is not
1. build a distribution with this patch on Centos 5.3 with php 5.2.11,
2. copy distribution to MacOSX Snow Leopard with php 5.3.1
3. ./configure --with-php_extension=yes && make
4. extension built fine
I then did the opposite,
1. build a distribution with this patch on MacOSX Snow Leopard with php 5.3.1
2. copy distribution to Centos 5.3 with php 5.2.11
3. ./configure --with-php_extension=yes && make
4. extension built fine
So it seems to work with different php's both forward in version and backward
in version.
Now I'm not a php expert, so I can't say there's not some subtle issue, but I
also grepped through the files and don't find the versions coded in there, just
looks like the rest of the autotools stuff, macros and makefiles.
So, it seems benign to me to include it, however, I can probably figure out
another way to do it if need be. I'd say my second attempt would probably
involve invoking phpize in the makefile, along with the configure script it
generates. That might look a little odd as you'd have just run the thrift
configure only to see configure type output happen when you make, but that's
probably not too bad. I guess the real question is would you accept any
solution where the extension is built/installed with the rest of thrift, I
don't want to spend more time messing with it, if there little or no chance of
inclusion.
> Provide configure option and make rules to build/install php extension
> ----------------------------------------------------------------------
>
> Key: THRIFT-854
> URL: https://issues.apache.org/jira/browse/THRIFT-854
> Project: Thrift
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Anthony Molinaro
> Attachments: php-ext.patch, thrift_protocol.ini
>
>
> I like to build and install the php extension at the same time I build the
> php and other thrift artifacts. The attached path adds the necessary logic
> to build and install the extension to work on redhat/centos/fedora machines.
> configure has a new option --with-php_extension=yes which will enable the
> compilation/installation of the extension, along with an environment variable
> PHP_CONFIG_PREFIX which controls where the .ini file for enabling the
> extension is installed. The one requirement for this to work is the person
> creating builds must have phpize installed (this prepares the autoconf
> artifacts to be appropriately added to the distribution). On
> Centos/Redhat/Fedora this is in the php-devel package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
