-1 Sorry to pop in so late. I've been meaning to get to tracking thrift development, and the last couple days seemed like a good opportunity, so I've been catching up on it and merging some of our stuff.
We build with quite a few of the generators disabled. The patch for THRIFT-133 to parse/t_program.h (r980498) added a check if the generator in a namespace declaration is known and throws if not. Makes sense, but this makes it impossible to pass the sanity checks that are run by "make install" in test when generators are disabled (ThriftTest.thrift requires java, cpp, rb, perl, csharp, js). Obviously re-enabling the generators is pretty easy, but seems like either the configure flags for generators should be removed, the tests should be modified so that the namespace declarations are auto-generated based on configuration, or warnings should be added to the configure I'd personally be in favor of removing the --disable-gen flags for "core" libraries. (that are specified in the test.thrift files). Though pre-processing them isn't that bad of an idea. Somewhat minor/corner-case issue. Seems like it might be a little unfriendly to newcomers who experiment, though. I'll open a jira issue. Bruce On Aug 18, 2010, at 1:59 PM, ro...@bufferoverflow.ch wrote: > +1 > > I've built the following languages successfully: > cpp, java, erlang, ruby, perl, python > > and the following available Unit Tests passed: > cpp, java > > see: > http://www.bufferoverflow.ch/hudson/job/Thrift-0.4.0/default/lastStableBuild/ > > > > > Quoting Bryan Duxbury <br...@rapleaf.com>: > >> Hi all, >> >> As discussed, in all the time it took for us to finally release Thrift 0.3, >> we've accumulated enough changes for Thrift 0.4! >> >> I propose we accept >> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as >> the official Thrift 0.4.0 release. >> >> I created this tarball by checking out URL: >> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running >> "./bootstrap.sh && ./configure && make dist". >> >> The GPG signature for this tarball can be found at >> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>. >> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38. >> dc. >> >> Please download, verify the signatures, untar, and install and test the >> libraries you are familiar with. We need your +1 votes to make the release! >> If you encounter any problems, please let me know immediately. This vote >> will close 72 hours from now. >> >> This release consists of 45 tickets that cover many bugs and performance >> improvements. Please refer to the CHANGES file for the full list. In >> addition, I've rolled back a commit to the PHP extension that was causing >> build errors on non-Mac platforms. >> >> -Bryan >> > > > > ---------------------------------------------------------------- > This message was sent using IMP, the Internet Messaging Program. >
