[ 
https://issues.apache.org/jira/browse/THRIFT-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900764#action_12900764
 ] 

Bryan Duxbury commented on THRIFT-857:
--------------------------------------

That patch looked great, so I committed it. However, I don't think we've 
addressed the problem actually raised in this issue yet, so I'm going to leave 
it open.

> tests run by "make install" fail if generators are disabled
> -----------------------------------------------------------
>
>                 Key: THRIFT-857
>                 URL: https://issues.apache.org/jira/browse/THRIFT-857
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 0.4
>         Environment: mac os
>            Reporter: Bruce Lowekamp
>            Priority: Minor
>         Attachments: generator-subnamespace.patch
>
>
> configuring with generators disabled (configure --disable-gen-java, for 
> example) produces a failed build because the tests run by "make install" 
> require the java, cpp, rb, perl, csharp, and js generators.  
> I would personally favor either removing those --disble-gen options 
> altogether, or adding a warning message in the configure --help output that 
> disabling those generators is not recommended/will cause test failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to