[
https://issues.apache.org/jira/browse/THRIFT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901110#action_12901110
]
Anthony Molinaro commented on THRIFT-414:
-----------------------------------------
I agree, I think thrift should assume utf-8 for all strings, document it
somewhere, and move on. If you need some other encoding you can convert on the
end, but for a language neutral serialization format utf-8 is lowest common
denominator (at least these days).
> Support non-UTF-8 in Java and C#
> --------------------------------
>
> Key: THRIFT-414
> URL: https://issues.apache.org/jira/browse/THRIFT-414
> Project: Thrift
> Issue Type: New Feature
> Components: C# - Compiler, C# - Library, Cocoa - Compiler, Cocoa -
> Library, Java - Compiler, Java - Library
> Reporter: David Reiss
> Attachments:
> 0001-THRIFT-414.-Non-UTF-8-string-support-for-Java.patch,
> v2-0001-THRIFT-414.-Non-UTF-8-string-support-for-Java.patch
>
>
> Java and C# Thrift assume that all strings should be UTF-8. A better
> approach would be:
> - Give the readString and writeString protocol methods an encoding
> parameter, probably defaulting to UTF-8 for compatibility and convenience.
> - Make generated struct readers and writers pass the argument to the
> protocol objects for each string.
> - Allow a type annotation to override the default UTF-8 encoding.
> - All other languages (except Python 3) should ignore the annotation, but it
> will serve as documentation for the application.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
