[ 
https://issues.apache.org/jira/browse/THRIFT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903433#action_12903433
 ] 

Bryan Duxbury commented on THRIFT-873:
--------------------------------------

I like all of this patch except for the separate JVMs. I know that's its 
probably a more responsible way to do things, but it makes the test run slower. 
Are you certain that this is what is necessary in order to make the test pass? 
Wouldn't it be possible for us just to clean up after ourselves in the test for 
TAsyncClientManager?

> Java tests fail due to Too many open files
> ------------------------------------------
>
>                 Key: THRIFT-873
>                 URL: https://issues.apache.org/jira/browse/THRIFT-873
>             Project: Thrift
>          Issue Type: Test
>          Components: Java - Library
>    Affects Versions: 0.4
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.5
>
>         Attachments: thrift-873.txt
>
>
> All of the tests run in the same JVM, and it seems like 
> TestAsyncClientManager is leaking sockets.
> As a quick fix, dropping that to use only 200 clients instead of 500, and 
> changing each unit test to run in its own JVM instead of sharing them.
> Also allowing the port used for binding the test servers to be configured 
> from the command line

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to