[
https://issues.apache.org/jira/browse/THRIFT-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906325#action_12906325
]
Roger Meier commented on THRIFT-807:
------------------------------------
I applied that patch on my current trunk version again.
The js unit test has still the same results, but with v2 patch the tutorial
example mentioned above works, especially the exception.
{code}
var work = new Work()
work.op = Operation.DIVIDE;
work.num1 = $("#num1").val();
work.num2 = $("#num2").val();
try{
result = client.calculate(1, work);
$('#result').val(result);
$('#result').css('color', 'black');
} catch(ouch) {
$('#result').val(ouch.why);
$('#result').css('color', 'red');
}
{code}
+1
> JavaScript: Initialization of Base Types with 0 instead of null
> ---------------------------------------------------------------
>
> Key: THRIFT-807
> URL: https://issues.apache.org/jira/browse/THRIFT-807
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler
> Affects Versions: 0.3
> Reporter: Roger Meier
> Attachments: THRIFT-807_initialize_with_null.patch,
> THRIFT-807_initialize_with_null.v2.patch
>
>
> I had a problem with the exception avaliable on the tutorial.
> i32 calculate(1:i32 logid, 2:Work w) throws (1:InvalidOperation ouch),
> It couldn't be thrown because initialization of numeric base types is done
> with 0 instead of null and the checks do compare against null.
> This was not visible with the Tests provided with first patch for JavaScript
> bindings above, the ThriftTest.thrift definition does not have a combination
> of a base type return value and an exception.
> I've made a patch that initializes the base types I16,I32, I64 and DOUBLE
> with null. This could probably solve other issues as well
> Regards
> Roger
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
