[
https://issues.apache.org/jira/browse/THRIFT-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910771#action_12910771
]
Bryan Duxbury commented on THRIFT-885:
--------------------------------------
Is this ready for commit?
> Url encoded strings never get decoded? How do we fix this?
> ----------------------------------------------------------
>
> Key: THRIFT-885
> URL: https://issues.apache.org/jira/browse/THRIFT-885
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler
> Affects Versions: 0.4
> Reporter: Jordan
> Assignee: T Jake Luciani
> Fix For: 0.5
>
> Attachments: charEscapingFix.diff,
> THRIFT-885_jordans_patch_and_testcase.patch,
> THRIFT-885_remove_encodeURIComponent.patch
>
>
> This is for the test java server that was written to test the client.
> Suppose you have a method such as testString(theTestString)
> If you call it from the javascript like so:
> client.testString("hello man");
> The string that your server implementation sees will be all crazy and url
> encoded.
> public static void testString(string theTestString) {
> // Inside here that string looks like "hello%20man".
> }
> We need it to be urlencoded when coming across the wire because we're using
> JSON as the protocol, but once it gets to thrift server code, it needs to be
> normal.
> So what's going on here? Inside of strings (of javascript objects) things
> like quotes and spaces are escaped. This is fine, but I do not believe that
> is part of the TJSONProtocol. This is something that is specific to having a
> js thrift client am I right? So where do we fix this?
> Edit: I had proposed a code fix which I do not believe to be the correct
> solution. Deleting- see future post for what I believe to be correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
